Skip to content

Make dpctl tensor device hashable, added equality comparison#1048

Merged
oleksandr-pavlyk merged 2 commits intomasterfrom
make-dpctl-tensor-Device-hashable
Jan 28, 2023
Merged

Make dpctl tensor device hashable, added equality comparison#1048
oleksandr-pavlyk merged 2 commits intomasterfrom
make-dpctl-tensor-Device-hashable

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Jan 27, 2023

Added dpctl.tensor.Device.__eq__ and dpctl.tensor.Device.__hash__ methods and tests.

import dpctl.tensor as dpt
x = dpt.empty(10)
y = dpt.empty(10)
assert x.device == y.device

The assertion used to fail, but returns True now.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@oleksandr-pavlyk
dpctl.tensor.Device.__eq__ and .__hash__ special methods added.
b0fa998 
Array API's Device object must support __eq__ special method.
Addition of __hash__ also allows to use Device object instances
as keys in dictionaries.
@oleksandr-pavlyk
Added tests for Device.__eq__ and Device.__hash__
3dda4f4
@oleksandr-pavlyk oleksandr-pavlyk changed the title Make dpctl tensor device hashable Make dpctl tensor device hashable, added equality comparison Jan 27, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 27, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1048/index.html

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jan 27, 2023

Coverage Status

Coverage: 82.097% (+0.02%) from 82.076% when pulling 3dda4f4 on make-dpctl-tensor-Device-hashable into 949711e on master.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 27, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_48 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit db8fe2f into master Jan 28, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 28, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 28, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_50 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk deleted the make-dpctl-tensor-Device-hashable branch March 23, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleksandr-pavlyk @coveralls