Merged
Conversation
Fixed violations of CFD. Made it work on Iris Xe.
This change made it possible to remove some uses of const_cast and made code simpler. Also used #pragma unroll in specialized CopyAndCast kernel where displacement is computed from multi-index.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1032/index.html |
Collaborator
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_11 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_11 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not add new functionality, but cleans up C++ sources of copy-and-casting kernels.
shape,src_stridesanddst_stridespointers.constqualifiers for some arguments in implementation functions to simplify code and to better reflect the intent.dpctl/tensor/libtensor/tests/test_copy.pyscript to run on Iris Xe without support for double precision floating point numbers and to comply with compute follows data.