Skip to content

Step NumPy pin to 1.22 in conda build config#1024

Merged
xaleryb merged 1 commit intoIntelPython:masterfrom
antonwolfy:step_numpy_pin
Dec 19, 2022
Merged

Step NumPy pin to 1.22 in conda build config#1024
xaleryb merged 1 commit intoIntelPython:masterfrom
antonwolfy:step_numpy_pin

Conversation

@antonwolfy
Copy link
Copy Markdown
Collaborator

@antonwolfy antonwolfy commented Dec 19, 2022 •
edited
Loading

Intel 2023.0 release includes NumPy 1.22.
Thus dpctl should switch pinning NumPy version to the same value in config file.

Otherwise it is impossible to correctly build dpctl, when there is no new 2023 compiler in the host environment. This is because the current NumPy 1.21 can't be installed with the new 2023 compiler.
As a result it leads to improper linkage of libDPCTLSyclInterface.so with libsycl.so.6, which came with 2023 compiler only and present in build env, but missing in the host env.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy
Copy link
Copy Markdown
Collaborator Author

antonwolfy commented Dec 19, 2022

A verification job array-api-conformity seems failed, because the PR is from forked repository and entire step couldn't post the result as a PR comment.
While the result of conformance tests looks OK (the same as in previous runs):

    MESSAGE: Array API standard conformance tests for dpctl=0.14.1dev0=py310h76be34b_24 ran successfully.
    Passed: 33
    Failed: 801
    Skipped: 280

@xaleryb xaleryb merged commit ab56ff0 into IntelPython:master Dec 19, 2022
@antonwolfy antonwolfy deleted the step_numpy_pin branch December 19, 2022 19:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 19, 2022

Array API standard conformance tests for dpctl=0.14.1dev0=py310h76be34b_24 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xaleryb xaleryb Awaiting requested review from xaleryb

@npolina4 npolina4 Awaiting requested review from npolina4

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

@diptorupd diptorupd Awaiting requested review from diptorupd

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy @xaleryb