Implemented and deployed validate_type_for_device<T>(q)#1018
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Dec 16, 2022
Merged
Implemented and deployed validate_type_for_device<T>(q)#1018oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
This check would produce more succint error message:
```
In [1]: import dpctl.tensor as dpt
In [2]: dpt.arange(0, 10, dtype='f8')
---------------------------------------------------------------------------
RuntimeError Traceback (most recent call last)
Input In [2], in <cell line: 1>()
----> 1 dpt.arange(0, 10, dtype='f8')
File ~/repos/dpctl/dpctl/tensor/_ctors.py:603, in arange(start, stop, step, dtype, device, usm_type, sycl_queue)
601 _step = sc_ty(1)
602 _start = _first
--> 603 hev, _ = ti._linspace_step(_start, _step, res, sycl_queue)
604 hev.wait()
605 if is_bool:
RuntimeError: Device Intel(R) Graphics [0x9a49] does not support type 'double'
```
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1018/index.html |
Collaborator
|
Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_20 ran successfully. |
antonwolfy
approved these changes
Dec 16, 2022
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented and deployed
validate_type_for_device<T>(q)utility function.This check would produce more succinct error message: