Skip to content

Added support for python -m dpctl -l to list platforms#1014

Merged
oleksandr-pavlyk merged 2 commits intomasterfrom
dpctl_module_lsplatform
Dec 13, 2022
Merged

Added support for python -m dpctl -l to list platforms#1014
oleksandr-pavlyk merged 2 commits intomasterfrom
dpctl_module_lsplatform

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Dec 11, 2022 •
edited
Loading

It is pretty cumbersome to use DPCTL to enumerate devices typing python -c "import dpctl; dpctl.lsplatform(verbosity=2)".

This change adds support for enumerating devices in all visible platforms to __main__, replacing the above with much easier to type python -m dpctl -f.

(dev_dpctl) opavlyk@opavlyk-mobl:~/repos/dpctl$ python -m dpctl --help
usage: __main__.py [-h] [--includes] [--cmakedir] [--library] [-l] [-e] [-s]

optional arguments:
  -h, --help       show this help message and exit
  --includes       Include flags dpctl headers.
  --cmakedir       CMake module directory, ideal for setting -DDPCTL_ROOT in CMake.
  --library        Linker flags for SyclInterface library.
  -f, --full-list  Enumerate system platforms, using dpctl.lsplatform(verbosity=2)
  -l, --long-list  Enumerate system platforms, using dpctl.lsplatform(verbosity=1)
  -s, --summary    Enumerate system platforms, using dpctl.lsplatform()
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 11, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1014/index.html

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 11, 2022

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_5 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Dec 11, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 82.34% when pulling 4952963 on dpctl_module_lsplatform into a3f8141 on master.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 11, 2022

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_6 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk
Added support for python -m dpctl -f to list platforms
4b8cf50 
```
(dev_dpctl) opavlyk@opavlyk-mobl:~/repos/dpctl$ python -m dpctl --help
usage: __main__.py [-h] [--includes] [--cmakedir] [--library] [-l] [-e] [-s]

optional arguments:
  -h, --help       show this help message and exit
  --includes       Include flags dpctl headers.
  --cmakedir       CMake module directory, ideal for setting -DDPCTL_ROOT in CMake.
  --library        Linker flags for SyclInterface library.
  -f, --full-list  Enumerate system platforms, using dpctl.lsplatform(verbosity=2)
  -l, --long-list  Enumerate system platforms, using dpctl.lsplatform(verbosity=1)
  -s, --summary    Enumerate system platforms, using dpctl.lsplatform()
```
@oleksandr-pavlyk
Added tests to test --long-list, --full-list and --summary
4952963
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented Dec 13, 2022 •
edited
Loading

I have force pushed to change short options used. It is now -f or --full-list, -l or --long-list, and -s or --summary.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 13, 2022

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_13 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 395f3bc into master Dec 13, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the dpctl_module_lsplatform branch December 13, 2022 14:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 13, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 13, 2022

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_13 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

@npolina4 npolina4 Awaiting requested review from npolina4

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-pavlyk @coveralls @antonwolfy