Skip to content

Added step to display version of clang-format used in pre-commit workflow#1009

Merged
oleksandr-pavlyk merged 3 commits intomasterfrom
add-diagonostic-clang-format
Dec 6, 2022
Merged

Added step to display version of clang-format used in pre-commit workflow#1009
oleksandr-pavlyk merged 3 commits intomasterfrom
add-diagonostic-clang-format

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Dec 6, 2022

Given unexpected pre-commit failure in #1008 due to clang-format, add a step to pre-commit.yaml workflow to output the version of clang-format used.

This would allow to quickly tell if the pre-commit failure was caused by version update of clang-format in GitHub runner image.

  • Have you provided a meaningful PR description?

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented Dec 6, 2022

clang-format was updated to 14.0.0-1ubuntu1.

clang-format started to change some source files which were up-to-snuff with earlier version. This likely means that our file .clang-format should be more stringent.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 6, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1009/index.html

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-diagonostic-clang-format branch from f9f0232 to 2a24de4 Compare December 6, 2022 14:30
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented Dec 6, 2022

The update to clang-format came with update of ubuntu-latest image to Ubuntu 22.04. Hence fixed it to Ubuntu 20.04, as this is the version we currently develop on.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Dec 6, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 82.032% when pulling 54bcbef on add-diagonostic-clang-format into e02b00a on master.

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Dec 6, 2022
Merged
5 tasks
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-diagonostic-clang-format branch from 2a24de4 to e842645 Compare December 6, 2022 15:17
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 6, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_28 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-diagonostic-clang-format branch from 53fcc47 to 8815a2f Compare December 6, 2022 17:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 6, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_29 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-diagonostic-clang-format branch from 8815a2f to 54bcbef Compare December 6, 2022 18:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 6, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_29 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 2747a14 into master Dec 6, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-diagonostic-clang-format branch December 6, 2022 18:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 6, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 6, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_29 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleksandr-pavlyk @coveralls