Skip to content

Fixed marginal memory leak in singleton class dpctl_capi #1000

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
dpctl_api-ctor-dtor
Nov 29, 2022
Merged

Fixed marginal memory leak in singleton class dpctl_capi #1000
oleksandr-pavlyk merged 1 commit intomasterfrom
dpctl_api-ctor-dtor

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Nov 25, 2022

dpctl_capi ctor initialize all members, dtor resets smart pointers

This addressed accessing uninitialized variables SDL tool warnings.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 25, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1000/index.html

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Nov 25, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 81.999% when pulling 0942321 on dpctl_api-ctor-dtor into 457450a on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the dpctl_api-ctor-dtor branch 12 times, most recently from 19b1a52 to 31215e6 Compare November 28, 2022 12:35
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Nov 28, 2022
Merged
4 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 28, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_10 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 28, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_12 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk
dpctl_capi ctor initialize all members, dtor resets smart pointers
0942321 
This addressed accessing uninitialized variables SDL tool warnings.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 28, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_12 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented Nov 28, 2022

Additional scan of this PR by the tool confirmed that access of uninitialized variable warnings and memory leak warnings are gone.

@oleksandr-pavlyk oleksandr-pavlyk merged commit a2edadb into master Nov 29, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the dpctl_api-ctor-dtor branch November 29, 2022 03:19
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 29, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 29, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_16 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleksandr-pavlyk @coveralls