Skip to content

Disabled instagram server checking #5207 - #5208

Merged
timgrossmann merged 8 commits into
InstaPy:masterfrom
wsbuck:master
Nov 11, 2019
Merged

Disabled instagram server checking #5207#5208
timgrossmann merged 8 commits into
InstaPy:masterfrom
wsbuck:master

Conversation

@wsbuck

@wsbuck wsbuck commented Nov 9, 2019

Copy link
Copy Markdown
Contributor
  • https://isitdownorjust.me website seems to be down
  • InstaPy fails the instagram server check and then aborts
  • Commented out check in login_util.py until a better website checker is found

* https://isitdownorjust.me website seems to be down
* InstaPy fails the instagram server check and then aborts
* Commented out check in login_util.py until a better website checker is found

@riccardovalente riccardovalente left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't needed. Just add want_check_browser=False in your quickstart file (only available in the latest builds).

@timgrossmann

Copy link
Copy Markdown
Collaborator

@wsbuck @riccardovalente Maybe it makes sense to set this parameter to be false by default? :)

@riccardovalente

Copy link
Copy Markdown
Contributor

@timgrossmann Maybe it makes sense to set this parameter to be false by default? :)

I agree

* removed changes to commented code in login_util.py
* updated want_check_browser to default to True
'
@jonjo156

Copy link
Copy Markdown

want_check_browser=False

only available in the latest builds of what exactly?

Thank you in advance

@timgrossmann

Copy link
Copy Markdown
Collaborator

@jonjo156 He meant the last version of InstaPy (0.6.5) you can get from PyPi 馃槃

@timgrossmann

Copy link
Copy Markdown
Collaborator

@wsbuck Thanks for the change, I've retriggered the CI, seemed like there was some error on black formatting.

If it runs through, we'll merge it 馃憤

@jonjo156

Copy link
Copy Markdown

@jonjo156 He meant the last version of InstaPy (0.6.5) you can get from PyPi 馃槃

Hi Tim,

Thanks for the reply. I have 0.6.5 and I have added want_check_browser=False in my second cell but still getting the server error. Can you help at all / does the want_chec_browser need to be in a specific cell ?

@timgrossmann

Copy link
Copy Markdown
Collaborator

@jonjo156 Sorry, please refer to the discord server for any kind of questions or help :)

@timgrossmann

Copy link
Copy Markdown
Collaborator

@wsbuck Messed up 馃槃 Could you please run the python black formatter and commit it again?

pip install black

black -t py34 .

@wsbuck

wsbuck commented Nov 10, 2019

Copy link
Copy Markdown
Contributor Author

Ok all checks passed now. Thanks for the help!

@timgrossmann
timgrossmann merged commit 4220e9d into InstaPy:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants