Proxy port fix - #5128
Merged
Merged
Conversation
Merge from timgrossmann/InstraPy master
When using a string as port number the proxy port is not set in firefox. Works when casted to an int
The API used before returned the IPv6 if avalible, and thus failed the check in "check_browser" in login_util.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG FIXED that prevented the proxy port to be set in firefox + using other API to check for current IP that supports always to return IPv4
Could be improved further to return IPv6 if the proxy_address given by the user is a IPv6 - but who uses IPv6 ;-)