Xpath, script and logical fixes of the new update - #4892
Merged
Conversation
converge
requested changes
Aug 18, 2019
converge
left a comment
Contributor
There was a problem hiding this comment.
I believe these small changes will make it better and ready to push to dev.
This was referenced Aug 21, 2019
Closed
Closed
Collaborator
|
@converge since you started this review, would be cool if you could resolve your changes :)) (when vacation time is over :P) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After changing of user agent(iphone x), instagram web page was changed.
Fixed xpaths and logics that make follow_commenters function worked.
Updated the checking of private user logic.
Fixed followers count xpath bug.
Updated the graphql script to get the ProfilePage information.
About the new commit:
I realised that, on some Instagram account, the old "window._sharedData.entry_data.ProfilePage[0]" variable is still working and the new one is not working. That's why I added a backup plan. It checks if "window.__additionalData" is defined, if not it tries to get info with "window._sharedData.entry_data.ProfilePage[0]".