Feature/joinpods config - #4679
Conversation
| self.skip_pod_comments = False | ||
|
|
||
| if skip_follows is True: | ||
| self.skip_pod_follows = True |
There was a problem hiding this comment.
what about self.skip_pod_follows = skip_follows ?
or if you also wanna have the None convered:
self.skip_pod_follows = skip_follows or False
There was a problem hiding this comment.
fixed in new commit
|
I just added or False no the value can never be None :) |
I think my understanding is a little bit different, but let's try to discuss this in a civil way.
Cheers. |
|
In my opinion, this config should be done at the join pods method. If you join a pod you can specify liking, following or commenting (or more than one). Then you just follow people for example and only get follows back. So if you decide that commenting and following is nothing special, you can just join pods for the liking feature. |
|
@ishandutta2007 but you should be able to decide what people are going to write to YOUR posts. So you should be able to disable commenting / following or liking at all. Right now its only all or nothing. Thats okay for the start but I can understand people don't want stupid comments so they don't it at all. |
So this is a step in the right direction, that works. Still doesn't solve the fact that I have to surrender the actions of my bot, create comments (which I simply never use on my bot) to participate in the pod. If I don't want my bot to follow or comments on others, that should be my decision. So I still think people should have the rights to control what their bot do (commenting and following) and also have what @ishandutta2007 propose: with the 2 sides (being: to configure what your bot do and what you receive), it becomes quite good and as always the community will find a balance. This PR, just provides the "configure what your bot do". |
|
@ishandutta2007 : again I don't really understand why you feel the need to yell at me, I am again having a civilized discussion.
if there is some kind of value system you want to enforce, feel free, 1000 likes = 1 comments, no problem. In any case, if you really want to enforce things (and that's also a good idea), then an external process should scan the participating bots database and verify that they really do what they say they would do (as far as I see, in the code, there is no prevention for somebody external to the system to upload a post in the firebase dabatase and have all the bots working on it without himself participating actively in it. Everybody has the source code and can patch their local version of instapy to do what they want to do. If you want a good system let's design it well so abuses are not possible. Closing this, I don't like the yelling part. |
|
It's open source, let's share the love S2. Pods are a great feature, but I also don't agree about do comments on pods, but let's keep the conversation open and respectful for new contributors, our only goal is a better tool for everyone. I'll have a closer look tomorrow and try to help the discussion somehow. |
There was a problem hiding this comment.
Please do these three changes for posts being uploaded and not posts downloaded as it violates the basic principles of pods and resubmit the PR
|
finally here, sorry for the delay. Can we just disable commenting and move on? |
|
what if I don't want to receive comments from Pods? |
|
the point is, most users don't want to receive random comments, that's why we should disable it, don't you think? |
That's my breakpoint, I will always prefer to use my time to share the love, and I won't continue the talk with this kind of insult. peace 💌 |
|
I vote for disabling comments. |
|
I will close this PR since @ishandutta2007 opened a new one which disabled commenting :) |
A simple set_pods_config function that can allow the user to configure following or commenting inside the pod