Skip to content

Feature/joinpods config - #4679

Closed
christophe-duc wants to merge 5 commits into
InstaPy:devfrom
christophe-duc:feature/joinpods-config
Closed

Feature/joinpods config#4679
christophe-duc wants to merge 5 commits into
InstaPy:devfrom
christophe-duc:feature/joinpods-config

Conversation

@christophe-duc

@christophe-duc christophe-duc commented Jul 18, 2019

Copy link
Copy Markdown
Collaborator

A simple set_pods_config function that can allow the user to configure following or commenting inside the pod

Comment thread instapy/instapy.py Outdated
Comment thread instapy/instapy.py Outdated
self.skip_pod_comments = False

if skip_follows is True:
self.skip_pod_follows = True

@breuerfelix breuerfelix Jul 18, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about self.skip_pod_follows = skip_follows ?
or if you also wanna have the None convered:
self.skip_pod_follows = skip_follows or False

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in new commit

@breuerfelix

Copy link
Copy Markdown
Collaborator

I just added or False no the value can never be None :)

breuerfelix
breuerfelix previously approved these changes Jul 18, 2019

@breuerfelix breuerfelix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@breuerfelix
breuerfelix dismissed their stale review July 18, 2019 15:58

ishan is right

@christophe-duc

Copy link
Copy Markdown
Collaborator Author

This feature should not be allowed at all.
Maybe you have not understood the idea of pods in the first place.
I thought you were talking about skipping comments for your own post.
But here your are skipping comments and following for the posts you are downloading. In other words you want to get your work done by uploading yours but not help others by engaging with them.
If everyone runs with such skip setting, pod posts will receive zero engagements.

You are welcome to write features configuring engagement for your posts, but not skip following or commenting for others post if the other person has not opted out.

I think my understanding is a little bit different, but let's try to discuss this in a civil way.

  1. Activating commenting or not: if you look at posts participating in the pod, you will see that they have 10's of comments that are the same, as the average instapy users always use the basic comments. In terms of engagement I think this is quite bad as it shows right away you are participating in an automated pod

  2. Activating following or not: again as this an automated pod, we follow and then unfollow. For example I am not very interested by being followed by a bot, which will unfollow me a couple days laters. I agree that here my idea should go a little bit farther in the sense, that I should also be able to say in the pod that I am not interested to be followed (so the other participants in the pod don't waste time on that)

  3. Liking: for me that the real interest of a pod, is to get my post into the top posts of a certain hash tag, because it is liked a lot. I think your current vision of the pod, does not allow this, and this is why I am not using it, and am trying to propose solution, so it's more usable to the rest of us.

Cheers.

@breuerfelix

Copy link
Copy Markdown
Collaborator

In my opinion, this config should be done at the join pods method.

If you join a pod you can specify liking, following or commenting (or more than one).

Then you just follow people for example and only get follows back. So if you decide that commenting and following is nothing special, you can just join pods for the liking feature.

@breuerfelix

Copy link
Copy Markdown
Collaborator

@ishandutta2007 but you should be able to decide what people are going to write to YOUR posts.

So you should be able to disable commenting / following or liking at all.

Right now its only all or nothing. Thats okay for the start but I can understand people don't want stupid comments so they don't it at all.

@christophe-duc

Copy link
Copy Markdown
Collaborator Author

ok see if this helps you understand:
current upload format is

{post_id, commenting_mode(10% or 30% or 90%)}

so to make it fully configurable it should be
{post_id, commenting_mode(0% or 10% or 30% or 90%), liking_mode(0% or default%), follow_me(True(default) or False)}

So this is a step in the right direction, that works.

Still doesn't solve the fact that I have to surrender the actions of my bot, create comments (which I simply never use on my bot) to participate in the pod. If I don't want my bot to follow or comments on others, that should be my decision.

So I still think people should have the rights to control what their bot do (commenting and following) and also have what @ishandutta2007 propose: {post_id, commenting_mode(0% or 10% or 30% or 90%), liking_mode(0% or default%), follow_me(True(default) or False)}

with the 2 sides (being: to configure what your bot do and what you receive), it becomes quite good and as always the community will find a balance.

This PR, just provides the "configure what your bot do".

@christophe-duc

christophe-duc commented Jul 18, 2019

Copy link
Copy Markdown
Collaborator Author

@ishandutta2007 : again I don't really understand why you feel the need to yell at me, I am again having a civilized discussion.

  • the bot do participate in the pod as it will be providing likes, it will give you 3,000 likes instead of 500 comments if it doesn't have to comment. How is that going to be leeching, if it does help you being in the top post of a tag?

if there is some kind of value system you want to enforce, feel free, 1000 likes = 1 comments, no problem. In any case, if you really want to enforce things (and that's also a good idea), then an external process should scan the participating bots database and verify that they really do what they say they would do (as far as I see, in the code, there is no prevention for somebody external to the system to upload a post in the firebase dabatase and have all the bots working on it without himself participating actively in it. Everybody has the source code and can patch their local version of instapy to do what they want to do.

If you want a good system let's design it well so abuses are not possible.

Closing this, I don't like the yelling part.

@converge

Copy link
Copy Markdown
Contributor

It's open source, let's share the love S2.

Pods are a great feature, but I also don't agree about do comments on pods, but let's keep the conversation open and respectful for new contributors, our only goal is a better tool for everyone.

I'll have a closer look tomorrow and try to help the discussion somehow.

@ishandutta2007 ishandutta2007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do these three changes for posts being uploaded and not posts downloaded as it violates the basic principles of pods and resubmit the PR

@converge

Copy link
Copy Markdown
Contributor

finally here, sorry for the delay.

Can we just disable commenting and move on?

@converge

Copy link
Copy Markdown
Contributor

what if I don't want to receive comments from Pods?

@converge

Copy link
Copy Markdown
Contributor

the point is, most users don't want to receive random comments, that's why we should disable it, don't you think?

@converge

Copy link
Copy Markdown
Contributor

I dont know if my english is different from yours.

That's my breakpoint, I will always prefer to use my time to share the love, and I won't continue the talk with this kind of insult. peace 💌

@daliborg

Copy link
Copy Markdown

I vote for disabling comments.

@breuerfelix

Copy link
Copy Markdown
Collaborator

I will close this PR since @ishandutta2007 opened a new one which disabled commenting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants