Skip to content

Skip User base on Profile Bio - #4576

Merged
breuerfelix merged 7 commits into
InstaPy:feature/skip-biofrom
AKwoKWH:AKwoKWH-patch-1_Skip_Profile_Bio
Jul 27, 2019
Merged

Skip User base on Profile Bio#4576
breuerfelix merged 7 commits into
InstaPy:feature/skip-biofrom
AKwoKWH:AKwoKWH-patch-1_Skip_Profile_Bio

Conversation

@AKwoKWH

@AKwoKWH AKwoKWH commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@AKwoKWH

AKwoKWH commented Jun 24, 2019

Copy link
Copy Markdown
Contributor Author

This is refer to my feature suggestions https://github.com/timgrossmann/InstaPy/issues/4531

and also others ppl request on filtering user using bio
Add your stop keywords in set_skip_users

Session.set_skip_users(skip_bio_keyword=['free shipping','Order','visa','paypal'])

@timgrossmann

timgrossmann commented Jun 28, 2019

Copy link
Copy Markdown
Collaborator

@AKwoKWH Could you please add a short section about this new feature to the DOCUMENTATION.md? 馃槉

For now, I've changed the base branch to develop since this is not only a fix but also some additional functionality.
We'll merge this into dev first and then with the next release into master.

Thank you very much for this addition!

@timgrossmann
timgrossmann changed the base branch from master to dev June 28, 2019 01:33
@breuerfelix

Copy link
Copy Markdown
Collaborator

@AKwoKWH sorry for mentioning the documentation again but it would be a pleasure for us to finally merge this pull request, so all here left is a small entry in the documentation file :)

It would be a shame if this pull request will be open for months only because the docs are left :D the earlier we merge this, the less problems we have while merging :)

@papillon-unix

Copy link
Copy Markdown

Can we use this new feature or not yet?
TypeError: set_skip_users() got an unexpected keyword argument 'skip_bio_keyword'
Does not work on my side, but would be very very usefull!!! Thx in advance

@papillon-unix

Copy link
Copy Markdown

It would be a shame if this pull request will be open for months only because the docs are left :D the earlier we merge this, the less problems we have while merging :)

Yes it would be terrible!! Can't we add it to the documentation by ourselves? It seems pretty clear how to use it!

@breuerfelix

Copy link
Copy Markdown
Collaborator

@papillon-unix could you be able to add some documentation and make a PR with this doc to master branch ?

so I can merge both at a time :)

@papillon-unix

papillon-unix commented Jul 11, 2019

Copy link
Copy Markdown

@breuerfelix I would love to, I will try to figure out how it works (am new on git) and let you know

@papillon-unix

papillon-unix commented Jul 27, 2019

Copy link
Copy Markdown

hi @breuerfelix I'm sorry, I tried to help but I really don't know how git works. I couldn't manage to make a pull request.
If it's helping I prepared the change for the documentation file :

##### Skip users based on bio

```python
session.set_skip_users(skip_bio_keyword=['free shipping','Order','visa','paypal'])
```
This will skip all users that have one these keywords on their bio.

@breuerfelix
breuerfelix changed the base branch from dev to feature/skip-bio July 27, 2019 14:44
@breuerfelix
breuerfelix merged commit f3d344f into InstaPy:feature/skip-bio Jul 27, 2019
@redsector72

Copy link
Copy Markdown
Contributor

I see this in the Documentation, but it is not yet working.
I receive
TypeError: set_skip_users() got an unexpected keyword argument 'skip_bio_keyword'

@breuerfelix

Copy link
Copy Markdown
Collaborator

@redsector72 could be that you forgot to update instapy ? cause i am able to pass this argument :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants