Barcelona | Oct-2025 | Ifeoma Osegbo | Sprint 3 | Coursework - #3
Open
Ify-O wants to merge 16 commits into
Open
Conversation
…acter in a string
…resentation of a number
…of times with error handling for negative counts
nsi88
suggested changes
Jan 16, 2026
nsi88
left a comment
There was a problem hiding this comment.
It looks good. There some rather minor details that would be good to adjust
| @@ -8,8 +8,19 @@ | |||
| // Then, write the next test! :) Go through this process until all the cases are implemented | |||
|
|
|||
| function getAngleType(angle) { | |||
There was a problem hiding this comment.
Do we need to support negative angles or angles >= 360?
If not worth throwing an error that they are not supported
|
|
||
| function isProperFraction(numerator, denominator) { | ||
| if (numerator < denominator) return true; | ||
| if (Math.abs(numerator) < denominator) { |
There was a problem hiding this comment.
I guess you need abs for the denominator as well
| function isProperFraction(numerator, denominator) { | ||
| if (numerator < denominator) return true; | ||
| if (Math.abs(numerator) < denominator) { | ||
| return true; |
There was a problem hiding this comment.
Not critical but useful. return true or return false are considered a "bad taste" in programming.
Usually instead of
if (condition) { return true } else { return false }
you do
return condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.