Skip to content

[Frontend/Course Admin] move tags page to settings page#841

Merged
anthonygego merged 4 commits into
masterfrom
tags_settings
Jul 15, 2022
Merged

[Frontend/Course Admin] move tags page to settings page#841
anthonygego merged 4 commits into
masterfrom
tags_settings

Conversation

@Drumor

@Drumor Drumor commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@anthonygego

Copy link
Copy Markdown
Member

There should be some HTML broken here as the footer text get pushed into the bootstrap card, at least on Chromium. You should also rather move the apply settings button outside of the card.

Comment thread inginious/frontend/pages/course_admin/settings.py Outdated
@anthonygego

Copy link
Copy Markdown
Member

LGTM

@anthonygego anthonygego merged commit b55107c into master Jul 15, 2022
@anthonygego anthonygego deleted the tags_settings branch July 15, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants