Skip to content

Keep up with the master :-) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dalehenrich merged 17 commits into from
Sep 23, 2021
Merged

Keep up with the master :-) #22

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1397779
Change ascii to utf8 encoding for text files in Pharo 9
Aug 15, 2021
652acb5
Change ascii to utf8 encoding for text files in Pharo 7
Aug 16, 2021
d305fd5
Move utf8 test file read/write test to Pharo specific test package an…
Aug 16, 2021
eee0956
Fixed wrong version comparison for expected failure in test
Aug 16, 2021
4ab1beb
Seems like the MultiByteFileStream did write utf8 already... (so this…
Aug 16, 2021
1c04d7b
Merge pull request #123 from SeasideSt/122-Replace-ascii-encoding-for…
Aug 16, 2021
99278d4
I always keep forgetting the version info... now at 1.7.3
Aug 16, 2021
55667df
Fix GRPackage dependency declaration
Sep 7, 2021
1c55905
Added a test for broken package dependencies
Sep 7, 2021
1f93dc5
Fix package resolution for Slime exception
Sep 7, 2021
026c637
Fix package test
Sep 7, 2021
1dcdab1
SequenceableCollection>>#sorted unnecessary in Grease-Pharo90-Core
astares Sep 17, 2021
ee61205
Merge pull request #126 from astares/125-SequenceableCollectionsorted…
Sep 23, 2021
48f401f
fix issue 127 (fileExists: in GemStone reports on existence of direct…
Sep 23, 2021
ba95d23
Added test for fileExists:
Sep 23, 2021
99b0213
version 1.7.5
Sep 23, 2021
21562c9
Merge pull request #128 from SeasideSt/issue-127
Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move utf8 test file read/write test to Pharo specific test package an… 
…d mark it as expected failure for Pharo 7 (and earlier)
  • Loading branch information
Johan Brichau committed Aug 16, 2021
commit d305fd5012acec83d6d773234c71ff95d594c8ba
11 changes: 6 additions & 5 deletions ...rease-Tests-Core.package/GRPlatformTest.class/instance/testReadWriteToFileInFolderText.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
tests-filestreams
testReadWriteToFileInFolderText
#('Ph''nglui mglw''nafh Cthulhu R''lyeh wgah''nagl fhtagn' 'Übèrstrîñgé') do:[ :text |
self
writeToFile: text
withFileNameDo:[ :fileName |
self assert: text equals: (GRPlatform current contentsOfFile: fileName binary: false) ] ].
| text |
text := 'Ph''nglui mglw''nafh Cthulhu R''lyeh wgah''nagl fhtagn'.
self
writeToFile: text
withFileNameDo:[ :fileName |
self assert: (text = (GRPlatform current contentsOfFile: fileName binary: false)) ]
10 changes: 10 additions & 0 deletions ...ry/Grease-Tests-Pharo-Core.package/GRPharoPlatformTest.class/instance/expectedFailures.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
running
expectedFailures
"UTF8 encoding/decoding for text files only available from Pharo7"
Smalltalk at: #SystemVersion ifPresent: [ :systemVersion |
| versionString |
versionString := systemVersion current version.
(versionString beginsWith: 'Pharo') ifTrue: [
systemVersion current major <= 7
ifTrue: [ ^ #(testReadWriteToFileInFolderTextUTF8) ] ] ].
^ #()
7 changes: 7 additions & 0 deletions ...ro-Core.package/GRPharoPlatformTest.class/instance/testReadWriteToFileInFolderTextUTF8.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
tests-filestreams
testReadWriteToFileInFolderTextUTF8
#('Übèrstrîñgé' '£ęλ~') do:[ :text |
self
writeToFile: text
withFileNameDo:[ :fileName |
self assert: text equals: (GRPlatform current contentsOfFile: fileName binary: false) ] ].