Skip to content

Fix typo in the bookshelf GCE example - #167

Closed
cactorium wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
cactorium:master
Closed

Fix typo in the bookshelf GCE example#167
cactorium wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
cactorium:master

Conversation

@cactorium

Copy link
Copy Markdown

This was causing the makeBookshelf script to fail

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 3, 2016
@cactorium

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 3, 2016
@cactorium

Copy link
Copy Markdown
Author

It looks like there's some problems in gce/startup-script.sh too; the jetty URL there no longer exists, and the service code assumes a System V Init, but the machine that's used now uses systemd. I have patches for that too but I wasn't sure whether it was better to try to use an older Debian image or to update it to use systemd

@cactorium

Copy link
Copy Markdown
Author

Closing because #168 fixes more problems

@cactorium cactorium closed this Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants