Left button support - Clean up - #43
Merged
Merged
Conversation
so it matches the tint property
BasThomas
reviewed
Mar 14, 2018
| case .right: | ||
| setRight(buttonIcon: buttonIcon, for: state) | ||
| break | ||
| case .left: |
Collaborator
There was a problem hiding this comment.
We could even make the switch only care about setting the right button:
let button: UIButton
switch type {
case .left:
button = leftButton
case .right
button = rightButton
}
button.setImage(buttonIcon, for: state)
Contributor
Author
There was a problem hiding this comment.
Good idea! I have implemented that 👍
Member
|
Mind fixing up the conflicts? Sent with GitHawk |
Collaborator
|
There shouldn’t be any? Sent with GitHawk |
Member
|
Oh might be a GitHawk bug 😬 button showed as conflicts Sent with GitHawk |
Collaborator
|
|
Member
|
Ya it turned green for me too. It happened in another PR, something is off Sent with GitHawk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up for the left button PR - #33