Skip to content

Barcelona| Class-Oct2025-1| Gbemisola Ikuegbuwa | Sprint-1| Structuring-And-Testing-Data Coursework/sprint 1 - #1

Open
Gbemisola-Fad wants to merge 13 commits into
mainfrom
coursework/sprint-1
Open

Barcelona| Class-Oct2025-1| Gbemisola Ikuegbuwa | Sprint-1| Structuring-And-Testing-Data Coursework/sprint 1 #1
Gbemisola-Fad wants to merge 13 commits into
mainfrom
coursework/sprint-1

Conversation

@Gbemisola-Fad

Copy link
Copy Markdown
Owner

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Barcelona| Class-Oct2025-1| Gbemisola Ikuegbuwa | Sprint-1| Structuring-And-Testing-Data Coursework/sprint 1
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Jezorko Jezorko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

console.log(indexOfDir)

// https://www.google.com/search?q=slice+mdn No newline at end of file
let dir = pathToDir.slice(indexOfDir + 1)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: dir should be Users/mitch/cyf/Module-JS1/week-1/interpret according to the diagram, but this results in just interpret.

@@ -6,4 +6,8 @@ const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;
// In this exercise, you will need to work out what num represents?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Missing explanation.

vi. const result */

// b) How many function calls are there?
/* There is only 6 function call in the program and the call is console.log(result)*/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note (non-blocking): Fun fact: there are more than 6 function calls, but some of them are implicit. For example, string interpolation at line 9 calls the toString method:

const example = {
  toString: () => {
    console.log("toString called!");
    return "example";
  }
};

console.log(`${example}`);

This will print

toString called!
example

// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer No newline at end of file
// e) What do you think the variable result represents? Can you think of a better name for this variable?
/* The variable result represent the movie duration formatted as a time string in the structure Hours:Minutes:Seconds ("2:26:24").
A better descriptive name for this variable for me would be "timeString". */

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): The more descriptive the better (;

Suggested change
A better descriptive name for this variable for me would be "timeString". */
A better descriptive name for this variable for me would be "formattedMovieDuration". */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants