Remove spd logging. - #22
Merged
Merged
Conversation
Add instructions on specifying logging level.
Collaborator
Author
|
Oh I have also remembered renaming the namespace to FairDataPipeline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public interface published spd logging types. This forces the codebase user into a dependency that cannot be revoked at a later date. I've removed the spd dependency and provided a FairDataPipeline logger. this can internally use spd should that be desired. Changing the internal log mechanism will no longer have an impact on the user. I have removed the logging parameters from the DataPipeline class and provided a mecanism to set the log level via an environment variable. This allows log levels to be specified at runtime and the levels can be changed without recompiling code.