Skip to content

Symfony 6.0 - #89

Closed
pierres wants to merge 3 commits into
Exercise:masterfrom
pierres:symfony-6.0
Closed

Symfony 6.0#89
pierres wants to merge 3 commits into
Exercise:masterfrom
pierres:symfony-6.0

Conversation

@pierres

@pierres pierres commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

This will allow to use Symfony 6.0 as dependency.

Tests did pass locally. I couldn't check Travis CI tests as these are no longer free and I lack s subscrption.

Resolves #85

@pierres pierres changed the title Symfony 6.0 Resolves #85: Symfony 6.0 Dec 23, 2021
@pierres pierres changed the title Resolves #85: Symfony 6.0 Symfony 6.0 Dec 23, 2021
@pierres

pierres commented Dec 23, 2021

Copy link
Copy Markdown
Contributor Author

I suggest to merge #88 as well

@bastien70

Copy link
Copy Markdown

I have the impression that the bundle is abandoned. No PR has been merge since December 2020. A way should be found to contact the owner of the bundle to ask for merge and release

@sdespont

Copy link
Copy Markdown

@bastien70 Last merge has been done by @HeahDude, you will found his email address on his profile page https://github.com/HeahDude

@bastien70

Copy link
Copy Markdown

@bastien70 Last merge has been done by @HeahDude, you will found his email address on his profile page https://github.com/HeahDude

Yes I already sent him an email yesterday morning, but no response

@pierres

pierres commented Dec 28, 2021

Copy link
Copy Markdown
Contributor Author

I have the impression that the bundle is abandoned. No PR has been merge since December 2020. A way should be found to contact the owner of the bundle to ask for merge and release

Good point. The organization website seems to be gone as well.

However: While looking into it I noticed that I barely use any features provided by this bundle and it was easy to directly use HTMLPurifier instead: archlinux-de/www.archlinux.de@ddd65cc

@bastien70

Copy link
Copy Markdown

@pierres There is another bundle which could be a good alternate : https://github.com/tgalopin/html-sanitizer-bundle

@pierres

pierres commented Dec 28, 2021

Copy link
Copy Markdown
Contributor Author

@pierres There is another bundle which could be a good alternate : https://github.com/tgalopin/html-sanitizer-bundle

Interesting; they also seem to prepare including a sanitizer in Symfony 6.1: https://github.com/symfony/html-sanitizer

@marksmanpilotcurler

Copy link
Copy Markdown

Have we all given up on this? It appears to be used by symfony/framework-bundle, so not good to let it die.

@pierres

pierres commented Mar 14, 2022

Copy link
Copy Markdown
Contributor Author

I don't see the framework-bundle depending on this package.

@Cryde

Cryde commented Apr 10, 2022

Copy link
Copy Markdown

You should keep this PR / discussion open to let people now there is an alternative that support PHP8 + SF6

https://github.com/tgalopin/html-sanitizer-bundle

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Symfony 6

5 participants