Skip to content

Support PHP 8.0 - #81

Merged
HeahDude merged 2 commits into
Exercise:masterfrom
pierres:patch-1
Dec 28, 2020
Merged

Support PHP 8.0#81
HeahDude merged 2 commits into
Exercise:masterfrom
pierres:patch-1

Conversation

@pierres

@pierres pierres commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@HeahDude

Copy link
Copy Markdown
Collaborator

Hello @pierres, many thanks for that PR! And happy holidays to you!

Could you please try to declare "XDEBUG_MODE=coverage" using the phpunit.xml.dist?
The CI is currently failing on the coverage step: https://travis-ci.org/github/Exercise/HTMLPurifierBundle/builds/751811763.

@HeahDude HeahDude added this to the 3.1 milestone Dec 28, 2020
@HeahDude

Copy link
Copy Markdown
Collaborator

Just noticed that the Xdebug issue is not caused by your changes, sorry. Thanks for working on it though.

@pierres

pierres commented Dec 28, 2020

Copy link
Copy Markdown
Contributor Author

Yes, the Xdebug issue was unrelated and caused by the Xdebug 3 update. I rebased the PR to have two separate commits.

@HeahDude
HeahDude merged commit 32f4709 into Exercise:master Dec 28, 2020
@HeahDude

Copy link
Copy Markdown
Collaborator

Thank you @pierres for this nice contribution, 3.1 is now tagged :).

Happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants