Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Samsung.xml - #15032

Merged
J0WI merged 2 commits into
EFForg:masterfrom
cschanaj:samsung.com-1
Apr 1, 2018
Merged

Update Samsung.xml#15032
J0WI merged 2 commits into
EFForg:masterfrom
cschanaj:samsung.com-1

Conversation

@cschanaj

@cschanaj cschanaj commented Mar 30, 2018

Copy link
Copy Markdown
Collaborator

Fix #10514, Fix #14942, Re-open #15031

P.S. I cannot reproduce the font breakage in #10514. Simplified the complicated regex used.

@cschanaj cschanaj mentioned this pull request Mar 30, 2018
@cschanaj cschanaj closed this Mar 30, 2018
@cschanaj cschanaj reopened this Mar 30, 2018
Comment thread src/chrome/content/rules/Samsung.xml Outdated
- help.content *
- m (503, akamai)
- origin *
- us *

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@J0WI
J0WI merged commit 59aaba4 into EFForg:master Apr 1, 2018
@terrorist96

terrorist96 commented Apr 1, 2018

Copy link
Copy Markdown
Contributor

P.S. I cannot reproduce the font breakage in #10514.

Me neither, but only because the rule is off by default right now. Enabling it, I see this:

Rule off:
image

Rule on:
image

I'll let you know if the issue still exists when the new version is pushed out.

@cschanaj
cschanaj deleted the samsung.com-1 branch April 2, 2018 00:43
@cschanaj

cschanaj commented Apr 2, 2018

Copy link
Copy Markdown
Collaborator Author

@terrorist96 noted with thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants