Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Removing broken How-To Geek rule - #1371

Closed
howtogeek wants to merge 1 commit into
EFForg:masterfrom
howtogeek:master
Closed

Removing broken How-To Geek rule#1371
howtogeek wants to merge 1 commit into
EFForg:masterfrom
howtogeek:master

Conversation

@howtogeek

Copy link
Copy Markdown

How-To Geek does not support HTTPS at this time, and this rule breaks images on the site.

How-To Geek does not support HTTPS at this time, and this rule breaks images on the site.
@jsha

jsha commented Apr 6, 2015

Copy link
Copy Markdown
Member

Since it looks like there are some URLs that work, I'd prefer adding a default_off="Breaks images" attribute to the ruleset tag.

1 similar comment
@jsha

jsha commented Apr 6, 2015

Copy link
Copy Markdown
Member

Since it looks like there are some URLs that work, I'd prefer adding a default_off="Breaks images" attribute to the ruleset tag.

@howtogeek

Copy link
Copy Markdown
Author

There are no URLs that work correctly. This is a completely broken rule.

Every URL that does respond to HTTPS just redirects you to HTTP.

I am working toward eventually possibly enabling HTTPS but this rule is causing a huge problem for my eventual implementation. Just because we bought a certificate doesn't mean the site actually works.

If you continue this, I will be forced to disable HTTPS everywhere since it's quite unnecessary for a static content website.

@jsha

jsha commented Apr 6, 2015

Copy link
Copy Markdown
Member

Apologies, I was reviewing pull requests in a hurry and didn't see that you are in fact the site owner.

Part of the reason we like to default_off rulesets is that if someone else comes along and tries to write a rule, they can see what the history is. For instance, in this case you might want to turn off the ruleset and add a comment saying "Per site owner, this site doesn't yet support HTTPS. Please don't re-enable until requested." That way if another ruleset author makes a similar mistake and thinks your site supports HTTPS, there will be a clear indication that it doesn't.

Thanks,
Jacob

@howtogeek

Copy link
Copy Markdown
Author

That seems reasonable then. As long as the rule gets turned off, we're getting a ton of complaints from readers.

@jsha jsha closed this in 28ac472 Apr 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants