Skip to content

OCT-2025-2 | Roman Pavlenko | Module-Complexity | Sprint 1 | Analyse and Refactor Functions - #1

Open
DraftRoman wants to merge 4 commits into
mainfrom
roman
Open

OCT-2025-2 | Roman Pavlenko | Module-Complexity | Sprint 1 | Analyse and Refactor Functions#1
DraftRoman wants to merge 4 commits into
mainfrom
roman

Conversation

@DraftRoman

Copy link
Copy Markdown
Owner

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • refactoring "callculate_sum_and_product" function. Used one loop for two operations and changed the name "sum" to the "total".
  • refactoring "find_common_items. Used sets for lists to delete duplicates
  • refactoring "has_pair_common_items". Add variable which consists sum - first number, and because it's simplifies the logic we don't need the second loop anymore.
  • refactoring "remove_duplicates" used set + loop to guarantee the positions of items.
  • all tests still passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant