Harden installer and add Copilot instructions#1087
Open
selfish666420 wants to merge 1 commit into
Open
Conversation
- add repo-specific Copilot instructions under .github\n- harden install.sh arg parsing, checksum handling, and Windows binary install\n- align test-infrastructure Dockerfile comment with actual deps\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Selfish666420 <jumper420666@proton.me>
Owner
|
Thanks for the installer fixes. The checksum lookup, Windows executable handling, and missing directory-argument validation are useful, but this PR mixes installer behavior, a Copilot instruction file, and a test-container documentation change. Please split the installer hardening into a focused bug PR with regression coverage and move the instruction/documentation work into a separate contribution. Installer and agent-instruction changes receive separate security review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates contributor ergonomics and installer reliability so setup is more predictable across environments.
It adds a new
.github/copilot-instructions.mdwith repo-specific build/test/lint/security commands, architecture notes, and key conventions for future coding sessions. It also hardensinstall.shby validating--dirusage, supporting wget fallback for checksum fetches, matching checksum entries by exact filename, and handling Windows.exeextraction/target naming correctly. In addition, it fixes a mismatched comment intest-infrastructure/Dockerfileso the documented dependencies align with what the image actually installs.Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)