feat(ui): add configurable host binding#1039
Open
Blamp26 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Blamp26 <98893587+Blamp26@users.noreply.github.com>
Owner
|
Thanks for making loopback the default and documenting the unauthenticated exposure risk. This is a security-sensitive 0.9.2-rc backlog enhancement. A non-loopback listener expands the product boundary even when explicitly configured, so merge is gated on a maintainer product-security decision. Any acceptable version must retain 127.0.0.1 as the default, require explicit opt-in, preserve strict CORS, and clearly warn that no authentication exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a persisted
--host=<IPv4>option for the embedded Graph UI.The default remains
127.0.0.1, preserving the existing localhost-only security posture and backward compatibility with older config files.Supported examples:
The implementation:
ui_hostalongside the existing UI settings;0support for tests;0.0.0.0as all interfaces;Fixes #229
Security
Non-loopback binding remains an explicit opt-in.
The warning explains that the UI:
The documentation recommends binding a specific LAN address instead of
0.0.0.0.Validation
make -f Makefile.cbm test— 6,012 passed, 1 platform-specific skipmake -f Makefile.cbm lint-ci CPPCHECK=/opt/cppcheck/bin/cppcheck CLANG_FORMAT=clang-format-20scripts/security-ui.shmake -j$(nproc) -f Makefile.cbm cbmmake -j$(nproc) -f Makefile.cbm cbm-with-ui127.0.0.1binding tested manually0.0.0.0binding and warning tested manually192.168.88.26binding tested manuallyPortability note
Windows runtime testing was not available locally. The Windows Winsock and
AF_INETpaths compile through the project code, with additional Windows validation left to the repository CI matrix.