[jsbox-app] Improve API accuracy, narrow types and fix bugs - #75383
Open
Gandum2077 wants to merge 3 commits into
Open
[jsbox-app] Improve API accuracy, narrow types and fix bugs#75383Gandum2077 wants to merge 3 commits into
Gandum2077 wants to merge 3 commits into
Conversation
Contributor
|
@Gandum2077 Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75383,
"author": "Gandum2077",
"headCommitOid": "6e9ce88112a5b3492cccd92143a46a05e180ea37",
"mergeBaseOid": "8883b899108653d7d047bbc898793f387b2f472e",
"lastPushDate": "2026-08-13T03:50:23.000Z",
"lastActivityDate": "2026-08-13T08:19:29.000Z",
"mergeOfferDate": "2026-08-13T08:20:08.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "jsbox-app",
"kind": "edit",
"files": [
{
"path": "types/jsbox-app/jsbox-app-tests.ts",
"kind": "test"
},
{
"path": "types/jsbox-app/src/basic.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/constant.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/drive.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/extend/qrcode.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/extend/share.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/extend/text.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/foundation/app.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/foundation/clipboard.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/foundation/device.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/foundation/http.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/foundation/network.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/foundation/prefs.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/foundation/system.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/function.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/input.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/media/audio.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/media/imagekit.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/media/pdf.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/media/photo.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/media/quicklook.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/network/server.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/network/socket.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/picker.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/sdk/contact.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/sdk/location.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/sdk/message.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/sdk/safari.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/sqlite.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/ssh.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/ui.d.ts",
"kind": "definition"
},
{
"path": "types/jsbox-app/src/widget.d.ts",
"kind": "definition"
}
],
"owners": [
"Gandum2077"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Bashamega",
"date": "2026-08-13T08:19:29.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 5275733189,
"ciResult": "pass"
} |
Contributor
|
🔔 @Gandum2077 — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
Bashamega
approved these changes
Aug 13, 2026
Contributor
|
@Gandum2077: Everything looks good here. I am ready to merge this PR (at 6e9ce88) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves type accuracy and fixes several bugs based on the JSBox documentation and runtime behavior verified on real devices.
Main changes:
numberandstringtypes to their corresponding JSBox constants or literal unions across UI, input, media, Photo, Widget, Socket, and other APIs.NSErrorfields, and support forNSDataorUint8Arraywhere applicable.Test cases have been added to the package test file to cover the updated declarations.
No package version change is required because this PR corrects and refines the declarations for the existing JSBox runtime.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.