Skip to content

[googlepay] Add nonce property to PaymentOptions - #75381

Open
dmengelt wants to merge 1 commit into
DefinitelyTyped:masterfrom
dmengelt:google-pay-add-csp-nonce-property
Open

[googlepay] Add nonce property to PaymentOptions#75381
dmengelt wants to merge 1 commit into
DefinitelyTyped:masterfrom
dmengelt:google-pay-add-csp-nonce-property

Conversation

@dmengelt

Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:
If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes:
  • Google Pay Release Notes
  • Google Pay Object Reference
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-automation

typescript-automation Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@dmengelt Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75381,
  "author": "dmengelt",
  "headCommitOid": "89e1a7573144a0fbf16d43fd0e34ca68d9457e1b",
  "mergeBaseOid": "8f494947aedf1aa8238676d55723ae7f62b7dd15",
  "lastPushDate": "2026-08-12T11:52:36.000Z",
  "lastActivityDate": "2026-08-12T12:55:21.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "googlepay",
      "kind": "edit",
      "files": [
        {
          "path": "types/googlepay/googlepay-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/googlepay/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Fluccioni",
        "Radu-Raicea",
        "fstanis",
        "mumpo",
        "socsieng",
        "JlUgia",
        "dmengelt",
        "aikimatthew",
        "stephenmcd"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "JlUgia",
      "date": "2026-08-12T12:55:21.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 5266450096,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Aug 12, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @Fluccioni @Radu-Raicea @fstanis @mumpo @socsieng @JlUgia @aikimatthew @stephenmcd — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-automation typescript-automation Bot moved this to Waiting for Code Reviews in Pull Request Status Board Aug 12, 2026
@typescript-automation typescript-automation Bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Aug 12, 2026
@typescript-automation typescript-automation Bot added the Owner Approved A listed owner of this package signed off on the pull request. label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package Owner Approved A listed owner of this package signed off on the pull request.

Projects

Status: Needs Maintainer Review

Development

Successfully merging this pull request may close these issues.

2 participants