[auto-generated] [pg] Add missing enableChannelBinding option - #75378
Open
carlosalbertolajr wants to merge 1 commit into
Open
[auto-generated] [pg] Add missing enableChannelBinding option#75378carlosalbertolajr wants to merge 1 commit into
carlosalbertolajr wants to merge 1 commit into
Conversation
Contributor
|
@carlosalbertolajr Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75378,
"author": "carlosalbertolajr",
"headCommitOid": "f67e5c5a91cce24d0795ccf68c10ce915cd0f5f2",
"mergeBaseOid": "1b053e38fb241d5ebfa0e426e78a6133906441c0",
"lastPushDate": "2026-08-11T20:23:19.000Z",
"lastActivityDate": "2026-08-11T20:23:19.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "pg",
"kind": "edit",
"files": [
{
"path": "types/pg/index.d.ts",
"kind": "definition"
},
{
"path": "types/pg/pg-tests.ts",
"kind": "test"
}
],
"owners": [
"pspeter3"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 5258434909,
"ciResult": "pass"
} |
Contributor
|
🔔 @pspeter3 — please review this PR in the next few days. Be sure to explicitly select |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgdocumentsenableChannelBindingas a configuration option for bothClientandPool, and the runtime reads it when selecting SCRAM-SHA-256-PLUS. However,ClientConfigcurrently omits the option, so documented configuration objects fail excess-property checking.This small change adds the optional boolean to
ClientConfig, from whichPoolConfigandPoolOptionsinherit, and exercises it through both constructors in the existing tests.We are using this option in an application and currently need a local type intersection to express it. The option was introduced in
pg@8.14.0and is present inpg@8.21.0, which these declarations currently target, so I have not changed the package version.Thank you for taking a look. I am happy to adjust the placement or test coverage if I have missed any package-specific convention.
pnpm test <package to test>.If changing an existing definition:
ClientandPool: https://github.com/brianc/node-postgres/blob/pg%408.21.0/docs/pages/features/ssl.mdx#L52-L64package.json. (Not applicable: this corrects an omission for an option introduced before the currently targeted version.)Validation performed: