[mparticle__web-sdk] Document logPurchase deprecation - #75377
Conversation
|
@rmi22186 Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75377,
"author": "rmi22186",
"headCommitOid": "7317db9809992c5e9c4236711b588c77befa4bb6",
"mergeBaseOid": "bbb4d3560b8db4a9591a3612d519c2cafd2fba01",
"lastPushDate": "2026-08-11T14:11:19.000Z",
"lastActivityDate": "2026-08-11T14:11:19.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "mparticle__web-sdk",
"kind": "edit",
"files": [
{
"path": "types/mparticle__web-sdk/index.d.ts",
"kind": "definition"
}
],
"owners": [
"asap",
"rmi22186"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 5254319196,
"ciResult": "pass"
} |
|
Hey @rmi22186, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @asap — please review this PR in the next few days. Be sure to explicitly select |
pnpm test <package to test>.If changing an existing definition:
package.json.Summary
Documents the existing
logPurchasedeprecation on both the globalmParticle.eCommerceAPI and named SDK instances. TypeScript-aware editors will direct developers tologProductActionwithProductActionType.Purchase.The existing global and instance type tests already invoke
logPurchase, covering both annotated declarations. No signatures or runtime behavior change.Validation
pnpm test mparticle__web-sdk --onlyTestTsNext