ssh2: add missing term property to PseudoTtyInfo - #75339
Open
pckilgore wants to merge 2 commits into
Open
Conversation
ssh2's server-side pty-req handler builds `{ term, cols, rows, width, height, modes }` (see lib/protocol/handlers.misc.js), but PseudoTtyInfo was missing `term`.
Contributor
|
@pckilgore Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 12 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75339,
"author": "pckilgore",
"headCommitOid": "60867b02bc2317c6dd66f9b0a1e2e1d7c1df3783",
"mergeBaseOid": "d1681105afb72067bf9dbd2ecfb7f400cb45ac5e",
"lastPushDate": "2026-08-01T05:50:18.000Z",
"lastActivityDate": "2026-08-02T11:12:09.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "ssh2",
"kind": "edit",
"files": [
{
"path": "types/ssh2/index.d.ts",
"kind": "definition"
},
{
"path": "types/ssh2/ssh2-tests.ts",
"kind": "test"
}
],
"owners": [
"tkQubo",
"rbuckton",
"wrboyce",
"hengkx",
"bragle",
"LucianBuzzo",
"dhensby"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "dhensby",
"date": "2026-08-02T11:12:09.000Z"
},
{
"type": "approved",
"reviewer": "bragle",
"date": "2026-08-01T14:11:38.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 5150062181,
"ciResult": "pass"
} |
Contributor
|
🔔 @tkqubo @rbuckton @wrboyce @hengkx @bragle @LucianBuzzo @dhensby — please review this PR in the next few days. Be sure to explicitly select |
dhensby
suggested changes
Aug 2, 2026
Contributor
|
@pckilgore One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PseudoTtyInfo(emitted on aSession's'pty'event) is missing thetermproperty.ref:
https://github.com/mscdex/ssh2/blob/master/lib/protocol/handlers.misc.js#L1092-L1116
Added
$ExpectTypecoverage inssh2-tests.tson the existing example server'ssession.once("pty", ...)handler (that block previously only exercised"exec", nothing touchedpty/termat all) so a future regression on anyPseudoTtyInfofield gets caught.