Skip to content

Fix uncaught NetworkX exceptions in TrackletStitcher.stitch() fallback #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deruyter92 wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −8
Open

Fix uncaught NetworkX exceptions in TrackletStitcher.stitch() fallback #3418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions deeplabcut/refine_training_dataset/stitch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,12 +670,18 @@ def stitch(self, add_back_residuals=True):
# Preflow push seems to work slightly better than shortest
# augmentation path..., and is more computationally efficient.
paths = []
for path in nx.node_disjoint_paths(self.G, "source", "sink", preflow_push, self.n_tracks):
temp = set()
for node in path[1:-1]:
self.G.remove_node(node)
temp.add(self._mapping_inv[node])
paths.append(list(temp))
try:
for path in nx.node_disjoint_paths(self.G, "source", "sink", preflow_push, self.n_tracks):
temp = set()
for node in path[1:-1]:
self.G.remove_node(node)
temp.add(self._mapping_inv[node])
paths.append(list(temp))
except nx.exception.NetworkXNoPath:
warnings.warn(
"Could not find disjoint paths connecting all tracklets. Continuing with partial results.",
stacklevel=2,
)
incomplete_tracks = self.n_tracks - len(paths)
remaining_nodes = set(self._mapping_inv[node] for node in self.G if node not in ("source", "sink"))
if len(remaining_nodes) > 0:
Expand Down Expand Up @@ -709,8 +715,17 @@ def stitch(self, add_back_residuals=True):
self.build_graph(list(remaining_nodes), max_gap=np.inf)
self.G.nodes["source"]["demand"] = -incomplete_tracks
self.G.nodes["sink"]["demand"] = incomplete_tracks
_, self.flow = nx.capacity_scaling(self.G)
paths += self.reconstruct_paths()
try:
_, self.flow = nx.capacity_scaling(self.G)
paths += self.reconstruct_paths()
except nx.exception.NetworkXUnfeasible:
warnings.warn(
"The fallback flow problem is also infeasible. "
f"Could not reconstruct {incomplete_tracks} "
f"remaining tracks from {len(remaining_nodes)} "
f"remaining tracklets.",
stacklevel=2,
)
self.paths = paths
if len(self.paths) != self.n_tracks:
warnings.warn(f"Only {len(self.paths)} tracks could be reconstructed.", stacklevel=2)
Expand Down
Loading