You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my previous attempt to add a timeout to deeplabcut.gui.window._check_for_updates(), the tests were failing on Windows and MacOS due to a difference in the multiprocessing package workflow across these different OSes. This attempt has therefore been reverted.
This Pull Requests proposes an addition of timeout to _check_for_updates() with tests that should be compatible with all 3 OS families (tested on Ubuntu 24.04 and Windows, @n-poulsen could you confirm this also works on MacOS please?).
With "fork", the child process inherits the memory space, file descriptors, and environment from the parent process. With "spawn", a fresh Python interpreter is started, and only the necessary objects (like the target function) are passed to the child process.
Therefore, to successfully run the tests on all OSes, the methods passed to multiprocessing cannot be defined in a local scope, because they cannot be pickled if it is the case, which then is not compatible with the "spawn" method.
Another consequence is that, in practice, deeplabcut needs to be reimported in each child process if using the "spawn" method (both when running test_call_with_timeout() and when running _check_for_updates()), which might take some time. This is not the case if new processes are started using "fork" method (Linux). @n-poulsen do you see any potential issue with this, that I didn't think of?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my previous attempt to add a timeout to
deeplabcut.gui.window._check_for_updates(), the tests were failing on Windows and MacOS due to a difference in themultiprocessingpackage workflow across these different OSes. This attempt has therefore been reverted.This Pull Requests proposes an addition of timeout to
_check_for_updates()with tests that should be compatible with all 3 OS families (tested on Ubuntu 24.04 and Windows, @n-poulsen could you confirm this also works on MacOS please?).