fix for modtools/create-unit - #1530
Open
dvantwisk wants to merge 5 commits into
Open
Conversation
ab9rf
requested changes
Feb 9, 2026
ab9rf
left a comment
Member
There was a problem hiding this comment.
This looks good to me, but needs a changelog entry
chdoc
reviewed
Aug 18, 2026
chdoc
left a comment
Member
There was a problem hiding this comment.
Apologies for the long delay. There simply wasn't anyone around to do proper reviews for a long time.
I gave it a look, and I didn't find anything that really stood out, except for two (outside of the modified part) where the way that things are done now have changed a bit.
Is there still interest in getting this merged?
| 'customProfession', | ||
| }) | ||
|
|
||
| if moduleMode then |
Member
There was a problem hiding this comment.
This also needs to be updated:
Suggested change
| if dfhack_flags.module then |
| return | ||
| end | ||
|
|
||
| local args = utils.processArgs({...}, validArgs) |
Member
There was a problem hiding this comment.
Should be updated to use the argparse module.
Suggested change
| local argparse = require('argparse') | |
| local args = argparse.processArgs({...}, validArgs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix changes the "arena spawn" paradigm that no longer works with the new version of DF to use
dfhack.units.create(). It guts most arena-specific code, changes the method in which skills and equipment are applied, updates unit block info, and teleports the unit to the specified location. There's likely more to do, but for now this seems to revive the script's functionality as it was before the steam version of DF.