Skip to content

Fix isolation level auto rollback bug #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laodouya merged 2 commits into from
Mar 1, 2019
Merged

Fix isolation level auto rollback bug #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25e3f59
Ignore nofile setrlimit in non-linux environment
Mar 1, 2019
896e060
Test begin/commit and error rollback in non read-uncommitted isolatio…
Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions xenomint/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,11 @@ func (s *State) write(
}
defer s.executer.Exec(`ROLLBACK TO "?"`, lastSeq)
}
if s.level != sql.LevelReadUncommitted {
// NOTE(leventeliu): this will cancel any uncommitted transaction, and do not harm to
// committed ones.
defer s.executer.Exec(`ROLLBACK`)
}
for i, v := range req.Payload.Queries {
var res sql.Result
if res, ierr = s.writeSingle(ctx, &v); ierr != nil {
Expand All @@ -426,10 +431,6 @@ func (s *State) write(
return
}
}
} else {
// NOTE(leventeliu): this will cancel any uncommitted transaction, and do not harm to
// committed ones.
s.executer.Exec(`ROLLBACK`)
}
// Try to commit if the ongoing tx is too large or schema is changed
if s.getSeq()-s.getLastCommitPoint() > s.maxTx ||
Expand Down
76 changes: 76 additions & 0 deletions xenomint/state_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,82 @@ func TestSerializableState(t *testing.T) {
})
}
})
Convey("The state should see changes", FailureContinues, func(c C) {
// Build transaction query
var (
count = 1000
queries = make([]types.Query, count+2)
req *types.Request
)
queries[0] = buildQuery(`BEGIN`)
for i := 0; i < count; i++ {
queries[i+1] = buildQuery(
`INSERT INTO t1(k, v) VALUES (?, ?)`, i, fmt.Sprintf("v%d", i),
)
}
queries[count+1] = buildQuery(`COMMIT`)
req = buildRequest(types.WriteQuery, queries)
// Send uncommitted transaction on background
var _, resp, err = state.Query(req, true)
c.So(err, ShouldBeNil)
c.So(resp.Header.RowCount, ShouldEqual, 0)

// Test isolation level
for i := 0; i < count; i++ {
_, resp, err = state.Query(buildRequest(types.ReadQuery, []types.Query{
buildQuery(`SELECT COUNT(1) AS cnt FROM t1`),
}), true)
So(resp.Payload, ShouldResemble, types.ResponsePayload{
Columns: []string{"cnt"},
DeclTypes: []string{""},
Rows: []types.ResponseRow{{Values: []interface{}{int64(count)}}},
})
}

req = buildRequest(types.WriteQuery, []types.Query{
buildQuery("DELETE FROM t1"),
})
_, resp, err = state.Query(req, true)
c.So(err, ShouldBeNil)
})
Convey("The state should not see changes because of failure query content", FailureContinues, func(c C) {
// Build transaction query
var (
count = 1000
queries = make([]types.Query, count+3)
req *types.Request
)
queries[0] = buildQuery(`BEGIN`)
for i := 0; i < count; i++ {
queries[i+1] = buildQuery(
`INSERT INTO t1(k, v) VALUES (?, ?)`, i, fmt.Sprintf("v%d", i),
)
}
queries[count+1] = buildQuery(`HAHA`)
queries[count+2] = buildQuery(`COMMIT`)
req = buildRequest(types.WriteQuery, queries)
// Send uncommitted transaction on background
var _, resp, err = state.Query(req, true)
c.So(err, ShouldNotBeNil)

// Test isolation level
for i := 0; i < count; i++ {
_, resp, err = state.Query(buildRequest(types.ReadQuery, []types.Query{
buildQuery(`SELECT COUNT(1) AS cnt FROM t1`),
}), true)
So(resp.Payload, ShouldResemble, types.ResponsePayload{
Columns: []string{"cnt"},
DeclTypes: []string{""},
Rows: []types.ResponseRow{{Values: []interface{}{int64(0)}}},
})
}

req = buildRequest(types.WriteQuery, []types.Query{
buildQuery("DELETE FROM t1"),
})
_, resp, err = state.Query(req, true)
c.So(err, ShouldBeNil)
})
})
})
}
23 changes: 13 additions & 10 deletions xenomint/xxx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"math/rand"
"os"
"path"
"runtime"
"sync"
"sync/atomic"
"syscall"
Expand Down Expand Up @@ -198,16 +199,18 @@ func setup() {

rand.Seed(time.Now().UnixNano())

// Set NOFILE limit
if err = syscall.Getrlimit(syscall.RLIMIT_NOFILE, &lmt); err != nil {
panic(err)
}
if lmt.Max < minNoFile {
panic("insufficient max RLIMIT_NOFILE")
}
lmt.Cur = lmt.Max
if err = syscall.Setrlimit(syscall.RLIMIT_NOFILE, &lmt); err != nil {
panic(err)
if runtime.GOOS == "linux" {
// Set NOFILE limit
if err = syscall.Getrlimit(syscall.RLIMIT_NOFILE, &lmt); err != nil {
panic(err)
}
if lmt.Max < minNoFile {
panic("insufficient max RLIMIT_NOFILE")
}
lmt.Cur = lmt.Max
if err = syscall.Setrlimit(syscall.RLIMIT_NOFILE, &lmt); err != nil {
panic(err)
}
}

// Initialze kms
Expand Down