Move target_oval_version to product_properties#13966
Conversation
91672ca to
23a655d
Compare
23a655d to
290e0a4
Compare
evgenyz
left a comment
There was a problem hiding this comment.
I don't like having both target_oval_version and target_oval_version_str, but that's a story for another day.
|
/retest |
vojtapolasek
left a comment
There was a problem hiding this comment.
Looks good, thank you.
|
@Mab879: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I am merging because this change affects Ubuntu only and Ubuntu group approved. |
1bd7235
into
ComplianceAsCode:master
There was a problem hiding this comment.
For lines https://github.com/Mab879/content/blob/290e0a4e87954c8302ba7a28d84941ac769623c5/CMakeLists.txt#L191-L193, is this still a valid warning?
There was a problem hiding this comment.
That is something i missed, no longer valid. The only limit on support now is the scanner used. I will get PR up shortly.
Description:
Move target_oval_version to product_properties
Rationale:
After reviewing #13918 I thought it might useful to config the OVAL version per product than global.
Review Hints:
rg "oval:schema_version" build/ssg-*ds.xml