Make Ansible in SELinux rules idempotent#13963
Merged
Merged
Conversation
There were 2 problems: 1. the .autorelabel file was created even if SELinux state was correct 2. the .autorelabel file was changed even if it existed because the task uses "touch" which always modified the file modification time Resolves: https://issues.redhat.com/browse/OPENSCAP-6255
Collaborator
|
/retest |
|
@jan-cerny: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Collaborator
Author
|
/packit build |
vojtapolasek
approved these changes
Oct 8, 2025
Collaborator
vojtapolasek
left a comment
There was a problem hiding this comment.
LGTM. Waiving failing Openshift test as changes in Ansible remediations do not influence it.
9542088
into
ComplianceAsCode:master
136 of 138 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 2 problems:
Resolves: https://issues.redhat.com/browse/OPENSCAP-6255
Review Hints:
./build_product --playbook-per-rule rhel9hosts: allinbuild/rhel9/playbooks/stig/selinux_state.ymlandbuild/rhel9/playbooks/all/selinux_not_disabled.ymlansible-playbook -u root -i YOUR_IP, build/rhel9/playbooks/stig/selinux_state.ymlat least twice and compare the output of the first run with the second run and so on, verify that the second and next runs don't change anything and that the output contains only "ok" or "skipping"build/rhel9/playbooks/all/selinux_not_disabled.yml--remediate-using ansible