Make Ansible file_existence template idempotent#13952
Merged
Merged
Conversation
Member
|
The testing farm failures seem oddly specific. Please take look. |
Member
Seems this is an issue on master. |
This will fix idempotency for rules like file_cron_allow_exists. The reason why the Ansible remediation in this rule wasn't idempotent is that it uses the "state: touch" which causes that the file modification time is always modified when the task is run. Resolves: https://issues.redhat.com/browse/OPENSCAP-6258
eee5809 to
b67d83c
Compare
Collaborator
Author
|
I have rebased this PR on the top of the latest upstream master branch. |
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mab879
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix idempotency for rules like file_cron_allow_exists. The reason why the Ansible remediation in this rule wasn't idempotent is that it uses the "state: touch" which causes that the file modification time is always modified when the task is run.
Resolves: https://issues.redhat.com/browse/OPENSCAP-6258
Review Hints:
./build_product --playbook-per-rule rhel9hosts: allinbuild/rhel9/playbooks/cis/file_cron_allow_exists.ymlansible-playbook -u root -i YOUR_IP, build/rhel9/playbooks/cis/file_cron_allow_exists.ymlat least twice and compare the output of the first run with the second run and so on, verify that the second and next runs don't change anything and that the output contains only "ok" or "skipping"--remediate-using ansible