Make Ansible in audit_rules_immutable idempotent#13950
Conversation
|
Can you please double check the Test farming failures? They might be valid. |
maybe this is a project synchronization (with contest) problem, let's restart the failing jobs to see if it helps. |
|
/packit retest-failed |
|
There is an issue in |
|
/packit retest-failed |
The current solution executed lineinfile task even if the correct line is present in the file. We will change the code to make the remediation idempotent. Resolves: https://issues.redhat.com/browse/OPENSCAP-6257
622039e to
65585fe
Compare
|
I have rebased this PR on the top of the latest upstream master branch. |
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The current solution executed lineinfile task even if the correct line is present in the file. We will change the code to make the remediation idempotent.
Resolves: https://issues.redhat.com/browse/OPENSCAP-6257
Review Hints:
./build_product --playbook-per-rule rhel9hosts: allinbuild/rhel9/playbooks/stig/audit_rules_immutable.ymlansible-playbook -u root -i YOUR_IP, build/rhel9/playbooks/stig/audit_rules_immutable.ymlat least twice and compare the output of the first run with the second run and so on, verify that the second and next runs don't change anything and that the output contains only "ok" or "skipping"--remediate-using ansible