Rework Ansible remediation in accounts_umask_interactive_users#13934
Merged
ggbecker merged 1 commit intoSep 29, 2025
Merged
Conversation
Rewrite the remediation that is currently using a shell command to use specialized Ansible modules instead. The reason for this change is that the task using the shell command isn't idempotent. Resolves: https://issues.redhat.com/browse/OPENSCAP-6248
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ggbecker
approved these changes
Sep 29, 2025
Member
ggbecker
left a comment
There was a problem hiding this comment.
I have run automatus and all tests pass.
I also changed the system and performed the ansible remediation manually and only during the first execution the system changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the remediation that is currently using a shell command to use specialized Ansible modules instead.
The reason for this change is that the task using the shell command isn't idempotent.
Resolves: https://issues.redhat.com/browse/OPENSCAP-6248