Make Ansible Tasks in GRUB rules idempotent#13927
Merged
Merged
Conversation
This commit will make Ansible remediations for rule grub2_disable_interactive_boot and grub2_disable_recovery idempotent. Specifically, the tasks that execute the bootloader regenerations (execute grubby or grub2mkconfig) will be guarded by condition that will cause these tasks will be executed only if the configuration files were changed by the previous lineinfile task in the remediation. Resolves: https://issues.redhat.com/browse/OPENSCAP-6242
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ggbecker
approved these changes
Sep 29, 2025
Member
ggbecker
left a comment
There was a problem hiding this comment.
I have run the playbooks on a RHEL9 system as instructed in the review hints and both playbooks didn't change the system when executed twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit will make Ansible remediations for rule grub2_disable_interactive_boot and grub2_disable_recovery idempotent. Specifically, the tasks that execute the bootloader regenerations (execute grubby or grub2mkconfig) will be guarded by condition that will cause these tasks will be executed only if the configuration files were changed by the previous lineinfile task in the remediation.
Resolves: https://issues.redhat.com/browse/OPENSCAP-6242
Review Hints:
./build_product --playbook-per-rule rhel9hosts: allin build/rhel9/playbooks/ospp/grub2_disable_recovery.yml and build/rhel9/playbooks/stig/grub2_disable_interactive_boot.ymlansible-playbook -u root -i 192.168.124.51, build/rhel9/playbooks/ospp/grub2_disable_recovery.ymlat least twice and compare the output of the first run with the second run and so on, verify that the second and next runs don't change anything and that the output contains only "ok" or "skipping"