Remove custom Ansible remediation from service_pcscd_enabled#13926
Merged
Conversation
This Ansible remediation isn't idempotent because it contains an unwanted call of the "ansible.builtin.command" module. It can be easily replaced by the remediation generated from the service_enabled template. The rule had a custom Ansible remeditaion as a fix for issue ComplianceAsCode#8002. However, this issue is no longer reproducible with the templated remeditaion, which means don't need the custom remediation anymore. Resolves: https://issues.redhat.com/browse/OPENSCAP-6243
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ggbecker
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Ansible remediation isn't idempotent because it contains an unwanted call of the "ansible.builtin.command" module. It can be easily replaced by the remediation generated from the service_enabled template. The rule had a custom Ansible remeditaion as a fix for issue #8002. However, this issue is no longer reproducible with the templated remeditaion, which means don't need the custom remediation anymore.
Resolves: https://issues.redhat.com/browse/OPENSCAP-6243