Sshd rekey limit update OVAL#13687
Merged
Merged
Conversation
added 3 commits
July 10, 2025 11:24
reflect precedence of dropin files Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
jan-cerny
approved these changes
Jul 11, 2025
| sed -i "/^\s*${SSHD_PARAM}.*/Id" /etc/ssh/sshd_config /etc/ssh/sshd_config.d/* | ||
| fi | ||
|
|
||
| echo "${SSHD_PARAM} 512M 1h" >> /etc/ssh/sshd_config /etc/ssh/sshd_config.d/good_config.conf |
Collaborator
There was a problem hiding this comment.
there needs to be just one file in the command, this doesn't add anything to the good_config.conf
Contributor
Author
There was a problem hiding this comment.
what a curious mistake hahaha. Fixed it
…hared.xml Co-authored-by: Jan Černý <jcerny@redhat.com>
Remove an unnecesary file mention Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
|
Code Climate has analyzed commit bfe9ba0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.7% (0.0% change). View more on Code Climate. |
mrkanon
approved these changes
Jul 14, 2025
jan-cerny
approved these changes
Jul 15, 2025
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
jcerny@fedora:~/work/git/scap-security-guide (pr/13687)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 sshd_rekey_limit
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-07-15-0802/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_sshd_rekey_limit
INFO - Script duplicated_param.pass.sh using profile (all) OK
INFO - Script param_conflict.fail.sh using profile (all) OK
INFO - Script bad_size.fail.sh using profile (all) OK
INFO - Script bad_size_directory.fail.sh using profile (all) OK
INFO - Script bad_time.fail.sh using profile (all) OK
INFO - Script bad_time_directory.fail.sh using profile (all) OK
INFO - Script correct_value.pass.sh using profile (all) OK
INFO - Script no_line.fail.sh using profile (all) OK
INFO - Script no_line_directory.fail.sh using profile (all) OK
INFO - Script rhel8_ospp_ok.pass.sh using profile xccdf_org.ssgproject.content_profile_ospp OK
INFO - Script rhel9_ospp_ok.pass.sh using profile xccdf_org.ssgproject.content_profile_ospp OK
INFO - Script correct_main_file_wrong_directory.fail.sh using profile (all) OK
INFO - Script correct_value_directory.pass.sh using profile (all) OK
INFO - Script param_conflict_directory.fail.sh using profile (all) OK
INFO - Script wrong_main_file_correct_directory.pass.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/13687)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --remediate-using ansible sshd_rekey_limit
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-07-15-0812/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_sshd_rekey_limit
INFO - Script duplicated_param.pass.sh using profile (all) OK
INFO - Script param_conflict.fail.sh using profile (all) OK
INFO - Script bad_size.fail.sh using profile (all) OK
INFO - Script bad_size_directory.fail.sh using profile (all) OK
INFO - Script bad_time.fail.sh using profile (all) OK
INFO - Script bad_time_directory.fail.sh using profile (all) OK
INFO - Script correct_value.pass.sh using profile (all) OK
INFO - Script no_line.fail.sh using profile (all) OK
INFO - Script no_line_directory.fail.sh using profile (all) OK
INFO - Script rhel8_ospp_ok.pass.sh using profile xccdf_org.ssgproject.content_profile_ospp OK
INFO - Script rhel9_ospp_ok.pass.sh using profile xccdf_org.ssgproject.content_profile_ospp OK
INFO - Script correct_main_file_wrong_directory.fail.sh using profile (all) OK
INFO - Script correct_value_directory.pass.sh using profile (all) OK
INFO - Script param_conflict_directory.fail.sh using profile (all) OK
INFO - Script wrong_main_file_correct_directory.pass.sh using profile (all) OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
sshd_rekey_limit. Make OVAL fail if a drop-in file overrides wrongly the main file configuration. Allow it to pass if the main file contains a wrong configuration but it is overridden correctly in a drop in file, because those have precedenceRationale:
-Current OVAL allows non compliant scenarios to pass
Review Hints: