Update Export SRG Script#13474
Merged
Merged
Conversation
jan-cerny
reviewed
May 19, 2025
| row['SRGID'] = srg_id | ||
| if 'disa' in rule_object.references: | ||
| row['CCI'] = ','.join(rule_object.references['disa']) | ||
| if rule_srgs: |
Collaborator
There was a problem hiding this comment.
I think that creating the value for the CCI key could be extracted to a separate function to reduce the code complexity.
e68d7d1 to
8e41668
Compare
|
Code Climate has analyzed commit 54ad0ee and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
May 22, 2025
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
I have quickly checked the generated spreadsheet for RHEL 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Make the spreadsheets easier to use