Make accounts password pam pwhistory remember rule use template for SLE etc#13343
Merged
dodys merged 2 commits intoApr 17, 2025
Conversation
If we have accounts_password_pam_pwhistory_remember/oval/shared.xml file it is also built for other platforms like SLE for sure, and it also overwrites the oval check generated by the template So having in mind that the accounts_password_pam_pwhistory_remember rule not using the template code seem to be valid only for ubuntu2404 the oval check script looks bet to be named after that particular platform
According to basic checks seems like rule is relevant for ubuntu platforms ubuntu2004 and ubuntu2404, for which the latter doesn't use the template so figured if condition will look simpler that way
|
Skipping CI for Draft Pull Request. |
|
Code Climate has analyzed commit fb9a129 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Collaborator
|
/test |
|
@jan-cerny: The Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
If we have accounts_password_pam_pwhistory_remember/oval/shared.xml file it is also built for other platforms like SLE for sure, and it also overwrites the oval check generated by the template. So having in mind that the accounts_password_pam_pwhistory_remember rule not using the template code seem to be valid only for ubuntu2404 the oval check script looks bet to be named after that particular platform
Simplify the condition in which the template will be used or not in the accounts_password_pam_pwhistory_remember/rule.yml
Review Hints: