Add tar.gz file of the build data streams#13321
Merged
jan-cerny merged 1 commit intoApr 15, 2025
Merged
Conversation
|
Code Climate has analyzed commit 3e2b72e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Apr 15, 2025
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
I have built files scap-security-guide-0.1.77.tar.gz and scap-security-guide-0.1.77.tar.gz.sha512 successfully using the instructions in the PR description. Also, I have verified their contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds tar.gz file of the built data streams. These will be part of the release artifacts.
Something to think about is file naming. I'm open to suggestions.
After this change we will a
tar.gzand.zipwith the built content. Then we also also have a.tar.bz2with the source. All of these files start withscap-security-guide-0.1.77. The only way to tell what is what (this is even true without this change) is by file size. The 100+ MB file is the built data streams and the smaller (~8.0 MB) is the source. Even today our release pages don't make that very clear.Rationale:
Addresses #13305
Review Hints:
These might take while.
rm -rf build/*cd buildcmake -G Ninja ..ninja -j$(nproc) zipfile