Skip to content

Update shared.yml#13320

Merged
Mab879 merged 1 commit into
ComplianceAsCode:masterfrom
ev-not-eve:master
Apr 15, 2025
Merged

Update shared.yml#13320
Mab879 merged 1 commit into
ComplianceAsCode:masterfrom
ev-not-eve:master

Conversation

@ev-not-eve
Copy link
Copy Markdown
Contributor

Description:

Added access_time and modification_time: preserve to rsyslog.conf exists rule

Rationale:

Ensures task is idempotent upon successive runs.

Added access_time and modification_time: preserve to rsyslog.conf exists rule, ensuring task is idempotent upon successive runs.
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 14, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 14, 2025

Hi @ev-not-eve. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Copy Markdown

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring' differs.
--- xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring
+++ xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring
@@ -45,6 +45,8 @@
   file:
     path: '{{ conf_files.0 }}'
     state: touch
+    access_time: preserve
+    modification_time: preserve
   when:
   - '"kernel" in ansible_facts.packages'
   - '"rsyslog" in ansible_facts.packages'

@Mab879 Mab879 self-assigned this Apr 14, 2025
@Mab879 Mab879 added this to the 0.1.77 milestone Apr 14, 2025
@Mab879 Mab879 added the Ansible Ansible remediation update. label Apr 14, 2025
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 821da8f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Copy Markdown
Member

Mab879 commented Apr 15, 2025

Thanks!

@Mab879 Mab879 merged commit d660572 into ComplianceAsCode:master Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ansible Ansible remediation update. needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants