Skip to content

Add dconf rules dependencies sle#13063

Merged
jan-cerny merged 4 commits into
ComplianceAsCode:masterfrom
teacup-on-rockingchair:add_dconf_rules_dependencies_sle
Mar 4, 2025
Merged

Add dconf rules dependencies sle#13063
jan-cerny merged 4 commits into
ComplianceAsCode:masterfrom
teacup-on-rockingchair:add_dconf_rules_dependencies_sle

Conversation

@teacup-on-rockingchair
Copy link
Copy Markdown
Contributor

@teacup-on-rockingchair teacup-on-rockingchair commented Feb 17, 2025

Description:

  • Add enable_dconf_user_profile rule to PCI-DSS and HIPAA profiles

Rationale:

  • other dconf rules depend on it to create profile directory

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 17, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jan-cerny jan-cerny added SLES SUSE Linux Enterprise Server product related. pci-dss Update Profile Issues or pull requests related to Profiles updates. labels Feb 19, 2025
@jan-cerny jan-cerny added this to the 0.1.77 milestone Feb 19, 2025
@teacup-on-rockingchair teacup-on-rockingchair force-pushed the add_dconf_rules_dependencies_sle branch from 6849351 to 0950b5a Compare February 27, 2025 21:02
@teacup-on-rockingchair
Add enable_dconf_user_profile to HIPAA profile
5d8863d 
Add rule to profile since dconf_gnome_remote_access_encryption
and dconf_gnome_remote_access_credential_prompt depend on it
@teacup-on-rockingchair
Add enable_dconf_user_profile to PCI-DSS profile
facc514 
Other dconf rules depend on that
@teacup-on-rockingchair
Set stable profiles for unit tests
ec476e3
@teacup-on-rockingchair teacup-on-rockingchair force-pushed the add_dconf_rules_dependencies_sle branch from 0950b5a to a7c9806 Compare March 2, 2025 12:25
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review March 2, 2025 14:51
@teacup-on-rockingchair teacup-on-rockingchair requested review from a team as code owners March 2, 2025 14:51
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 2, 2025
@teacup-on-rockingchair teacup-on-rockingchair force-pushed the add_dconf_rules_dependencies_sle branch from a7c9806 to e29062e Compare March 2, 2025 14:57
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Mar 2, 2025

Code Climate has analyzed commit e29062e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 62.0% (0.0% change).

View more on Code Climate.

jan-cerny
jan-cerny approved these changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-cerny jan-cerny self-assigned this Mar 4, 2025
@jan-cerny jan-cerny merged commit 4e32e0b into ComplianceAsCode:master Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels

pci-dss SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.77

Development

Successfully merging this pull request may close these issues.

2 participants

@teacup-on-rockingchair @jan-cerny