Skip to content

Add a default profile for Ubuntu2404 to add all rules to the datastream#13023

Merged
dodys merged 1 commit into
ComplianceAsCode:stabilization-v0.1.76from
mpurg:ubuntu2404_default_profile
Feb 12, 2025
Merged

Add a default profile for Ubuntu2404 to add all rules to the datastream#13023
dodys merged 1 commit into
ComplianceAsCode:stabilization-v0.1.76from
mpurg:ubuntu2404_default_profile

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Feb 11, 2025

Description:

  • Add a default profile for Ubuntu 2404 to add all rules to the datastream

Rationale:

  • Fixes issue with unselected rules not being added to the datastream by default

@mpurg mpurg requested a review from a team as a code owner February 11, 2025 12:11
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 11, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 11, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpurg mpurg force-pushed the ubuntu2404_default_profile branch from f12b650 to 187d153 Compare February 11, 2025 12:34
@dodys dodys self-assigned this Feb 11, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Profile Issues or pull requests related to new Profiles. labels Feb 11, 2025
@dodys dodys added this to the 0.1.76 milestone Feb 11, 2025
Comment thread products/ubuntu2404/profiles/default.profile Outdated
By default, the unselected rules are not added to the datastream.
@mpurg mpurg force-pushed the ubuntu2404_default_profile branch from 187d153 to 0bac91f Compare February 12, 2025 08:32
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 65ab179 into ComplianceAsCode:stabilization-v0.1.76 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot. New Profile Issues or pull requests related to new Profiles. Ubuntu Ubuntu product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants