Skip to content

Ubuntu 24.04: Implement rule 5.3.2.2 Ensure pam_faillock module is enabled#12779

Merged
dodys merged 3 commits into
ComplianceAsCode:masterfrom
alanmcanonical:ubt24_5322
Jan 10, 2025
Merged

Ubuntu 24.04: Implement rule 5.3.2.2 Ensure pam_faillock module is enabled#12779
dodys merged 3 commits into
ComplianceAsCode:masterfrom
alanmcanonical:ubt24_5322

Conversation

@alanmcanonical
Copy link
Copy Markdown
Contributor

@alanmcanonical alanmcanonical commented Jan 6, 2025

Description:

  • Implement rule 5.3.2.2 Ensure pam_faillock module is enabled

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 5.3.2.2

@alanmcanonical alanmcanonical requested a review from a team as a code owner January 6, 2025 19:52
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 6, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 6, 2025

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@alanmcanonical alanmcanonical force-pushed the ubt24_5322 branch 3 times, most recently from 5c148d7 to a9d3f1f Compare January 6, 2025 21:37
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. New Rule Issues or pull requests related to new Rules. labels Jan 7, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 7, 2025
@dodys dodys self-assigned this Jan 7, 2025
mpurg
mpurg requested changes Jan 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some fail tests (missing pam_faillock.so, commented, ...)

@alanmcanonical
Copy link
Copy Markdown
Contributor Author

alanmcanonical commented Jan 8, 2025

Please add some fail tests (missing pam_faillock.so, commented, ...)

Added

@alanmcanonical alanmcanonical mentioned this pull request Jan 9, 2025
Merged
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Jan 10, 2025

Code Climate has analyzed commit d145e2a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

mpurg
mpurg approved these changes Jan 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

dodys
dodys approved these changes Jan 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 6f3c152 into ComplianceAsCode:master Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

@mpurg mpurg mpurg approved these changes

Assignees

@dodys dodys

Labels

CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.76

Development

Successfully merging this pull request may close these issues.

3 participants

@alanmcanonical @dodys @mpurg